tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: Bug in B2C converter WAS: svn commit: r568307 - /tomcat/trunk/java/org/apache/tomcat/util/buf/B2CConverter.java
Date Thu, 28 Feb 2008 00:08:28 GMT
Remy Maucherat wrote:
> On Wed, 2008-02-27 at 16:04 -0700, Filip Hanik - Dev Lists wrote:
>   
>> Remy Maucherat wrote:
>>     
>>>> unfortunately, the "elegant" solution caused a regression :(
>>>> http://issues.apache.org/bugzilla/show_bug.cgi?id=44494
>>>> I tested this with the inelegant (original proposed) patch and it
>>>> worked 
>>>> fine, so I'm gonna fix this in trunk and propose the patch to 6.0
>>>>     
>>>>         
>>> Ok, and there's no time to think ? A patch must be applied within
>>>       
>> the
>>     
>>> next 5 seconds ? (probably because it was not your patch, I
>>>       
>> assume :) )
>>     
>>>   
>>>       
>> and lets cut the crap with the 5 second bs, I worked on this last
>> night, 
>> and then again this morning when I saw how complicated the new patch
>> had 
>> gotten and there was a very easy fix.
>>     
>
> I'm looking your stacktrace which is supposedly:
> SEVERE: Servlet.service() for servlet jsp threw exception
> java.lang.ArrayIndexOutOfBoundsException: 8192
>         at
> org.apache.tomcat.util.buf.CharChunk.substract(CharChunk.java:388)
>         at
> org.apache.catalina.connector.InputBuffer.read(InputBuffer.java:368)
>         at
> org.apache.catalina.connector.CoyoteReader.read(CoyoteReader.java:93)
>
> This makes me think there's a straight issue in CharChunk (I suppose the
> problem is that realReadChars gets called with len = 0; if it handled
> that scenario, things should be fine).
>   
the old char chunk worked just fine, so why not stick with it. the error 
above is a result of B2CConverter and InputBuffer being modified


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message