Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of skibaa@gmail.com designates
 72.14.202.182 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references;
        b=Q1td7ZoGadVO/9uOJmguYEnTGdQ4amKpayXYkPjvXQuUlsq+WtFts2RtAHW3rdExkl9WqG5g8s22BqkxqgRJcYk3Uq4NuAcINJrOdVp9x/NK6U6UJyUV9OJCvmEoufSr4YZTGuYN3/BS4yIdaoUOpPSxwc/n5JxanCKQAH288Yw=
Message-ID: <e38a56020801100505x5abac9e4j95bdafbe37a0321a@mail.gmail.com>
Date: Thu, 10 Jan 2008 15:05:37 +0200
From: "Andrew Skiba" <skibaa@gmail.com>
To: "Tomcat Developers List" <dev@tomcat.apache.org>
Subject: Re: backlog measurement
In-Reply-To: <e38a56020801100147y22db2b27m51a4e2296aef85e5@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative;
	boundary="----=_Part_22683_14483304.1199970337563"
References: <e38a56020801100047p1586bfedu2a8c8bded313a186@mail.gmail.com>
	 <4026A09E-5396-4671-BBCE-DF6E219398A6@objektpark.de>
	 <e38a56020801100147y22db2b27m51a4e2296aef85e5@mail.gmail.com>

------=_Part_22683_14483304.1199970337563
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

It works with tomcat from trunk now. I opened a bug and attached a patch for
the new code. License and author specified as you said. Please review.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44199

On Jan 10, 2008 11:47 AM, Andrew Skiba <skibaa@gmail.com> wrote:

> Hi Peter, thanks for your reply,
>
> The name of Harish appears in the code by mistake. I started from
> DefaultSocketFactory written by Harish, but nothing remained from the
> original. So I am the author and I will include Apache license in the code.
>
> You are correct, it works only with java 5, and I checked it only with
> tomcat 5.5. I will check it with tomcat 6 as well.
>
> I will open a bug and attach the fixed code.
>
> Andrew.
>
>
> On Jan 10, 2008 11:30 AM, Peter Rossbach <pr@objektpark.de> wrote:
>
> > HI Andrew,
> >
> > good idea, but why you can contribute a code from  Harish Prabandham
> > (db@eng.sun.com).
> > We can only accept contributions from orignal author and with Apache
> > 2 license included!
> >
> > I seems that this only work with java 5 and the code is designed for
> > JIO HTTP tomcat 5.5.
> >
> > Open a bug report, then we can discuss your contribution.
> >
> > Regards,
> > Peter
> >
> >
> > Am 10.01.2008 um 09:47 schrieb Andrew Skiba:
> >
> > > Hello,
> > >
> > > I want to contribute a custom SocketFactory allowing to analyze the
> > > utilization of acceptConnection attribute of a Connector. In a
> > > properly configured production system, there should be rare
> > > situations where connections wait for a worker thread to be
> > > handled. Our client complained on high latency of web requests, but
> > > the measurement on servlet did not show high latency. So we wanted
> > > to know the number of connections which wait in socket backlog and
> > > were not accepted yet.
> > >
> > > I solved this problem by writing a custom SocketFactory, which
> > > accepts connections immediately and puts it in my queue until a
> > > call to accept() will take them. So the number of waiting
> > > connections can be monitored via JMX.
> > >
> > > To activate this factory, the declaration of the corresponding
> > > Connector in server.xml should be changed like in the following
> > > example.
> > >
> > >  <Connector port="8080" maxHttpHeaderSize="8192"
> > >                maxThreads="10" minSpareThreads="5" maxSpareThreads="7"
> >
> > >                enableLookups="false" redirectPort="8443"
> > > acceptCount="10"
> > >                connectionTimeout="2000" disableUploadTimeout="true"
> > >
> > >
> > > socketFactory="org.apache.tomcat.util.net.BacklogMeasuringServerSocket
> > > Factory"/>
> > >
> > >
> > > No changes in existing classes are required.
> > >
> > > Please review the code in the attachment.
> > >
> > >
> > > Andrew Skiba.
> > > <BacklogMeasuringServerSocketFactory.java>
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> > > For additional commands, e-mail: dev-help@tomcat.apache.org
> >
> >
>

------=_Part_22683_14483304.1199970337563--