tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 44281] New: - apache doesn't start when worker name is "*" in exclusion rule.
Date Wed, 23 Jan 2008 07:32:28 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=44281>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44281

           Summary: apache doesn't start when worker name is "*" in
                    exclusion rule.
           Product: Tomcat 5
           Version: Nightly Build
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Native:JK
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: mashmk02@gmail.com


hi

I tested mod_jk 1.2.27-dev (checkout from trunk head) on RHEL 4u5, i got segfault. 

When the worker name specified for the exclusion rule is "*", the apache doesn'
t start. 

ex.)
JkUnMount /*.jpg *
or
!/*.jpg=*

Index: mod_jk/native/common/jk_uri_worker_map.c
===================================================================
--- mod_jk/native/common/jk_uri_worker_map.c    (revision 614422)
+++ mod_jk/native/common/jk_uri_worker_map.c    (working copy)
@@ -468,6 +468,8 @@

     for (i = 0; i < IND_NEXT(uw_map->size); i++) {
         uri_worker_record_t *uwr = IND_NEXT(uw_map->maps)[i];
+        if(uwr->match_type & MATCH_TYPE_NO_MATCH)
+            continue;
         jk_worker_t *jw = wc_get_worker_for_name(uwr->worker_name, l);
         if (JK_IS_DEBUG_LEVEL(l))
             jk_log(l, JK_LOG_DEBUG,

My best regards. 

P.S.
The following patch was made because it was not displayed with status worker 
when the worker name was "*". 

Index: mod_jk/native/common/jk_status.c
===================================================================
--- mod_jk/native/common/jk_status.c    (revision 614422)
+++ mod_jk/native/common/jk_status.c    (working copy)
@@ -1358,7 +1358,7 @@
     if (uw_map) {
         for (i = 0; i < uw_map->size[uw_map->index]; i++) {
             uri_worker_record_t *uwr = uw_map->maps[uw_map->index][i];
-            if (strcmp(uwr->worker_name, worker)) {
+            if (strcmp(uwr->worker_name, worker)&&strcmp(uwr->worker_name,
"*")) {
                 continue;
             }
             count++;
@@ -1409,7 +1409,7 @@
     for (i = 0; i < uw_map->size[uw_map->index]; i++) {
         uri_worker_record_t *uwr = uw_map->maps[uw_map->index][i];

-        if (strcmp(uwr->worker_name, worker)) {
+        if (strcmp(uwr->worker_name, worker)&&strcmp(uwr->worker_name, "*"))
{
             continue;
         }
         (*count_ptr)++;

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message