tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 04 Jan 2008 18:30:47 GMT
Filip Hanik - Dev Lists wrote:
> Mark Thomas wrote:
>> fhanik@apache.org wrote:
>>  
>>> +  -1: fhanik - lets not do e.printStackTrace, handle the error and
>>> log it correctly,
>>>     
>>
>> Fair point. I'll fix that.
>>
>> also, have the diff only change lines that are actually changed. makes it
>> easier to review
>>
>> Which lines do you mean? The diff looks normal to me.
>>   
> pretty much all the lines before
> "public class SerializablePrincipal" are non functional changes, but
> cosmetic.

Got it. I didn't realise you meant "not cosmetic changes" when you wrote
"actually changed"

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message