tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r608666 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Fri, 04 Jan 2008 16:53:45 GMT
:)
what I meant was, it still contains non functional changes, such as 
reordering of imports, breaking up code lines etc.
If I read the patch correctly, the only functional changes are really 
only during readPrincipal and writePrincipal, yet so many other lines 
are changed.

does that make sense, ie, the patch is fine, and works, and will get my 
+1, but it will make it hard for anyone else trying to review whether to 
functionality is compatible, still has to review 70% of lines that do 
nothing

Filip


markt@apache.org wrote:
> Author: markt
> Date: Thu Jan  3 14:54:47 2008
> New Revision: 608666
>
> URL: http://svn.apache.org/viewvc?rev=608666&view=rev
> Log:
> Address Filip's concerns with a new patch.
>
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt
>
> Modified: tomcat/tc6.0.x/trunk/STATUS.txt
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=608666&r1=608665&r2=608666&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/STATUS.txt (original)
> +++ tomcat/tc6.0.x/trunk/STATUS.txt Thu Jan  3 14:54:47 2008
> @@ -50,10 +50,9 @@
>  
>  * Fix http://issues.apache.org/bugzilla/show_bug.cgi?id=43840
>    Include user principal if possible when serializing / de-serializing
> -  http://svn.apache.org/viewvc?rev=607596&view=rev
> -  http://svn.apache.org/viewvc?rev=607597&view=rev
> -  +1: markt, funkman
> -  -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly,
also, have the diff only change lines that are actually changed. makes it easier to review
> +  http://people.apache.org/~markt/dev/bug43840.txt
> +  +1: markt
> +  -1:
>  
>  * Improve Jasper docs. Note rather than remove unused option, it will be
>    deprecated in 6.0.x.
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message