tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r608329 - /tomcat/tc6.0.x/trunk/STATUS.txt
Date Thu, 03 Jan 2008 22:59:45 GMT
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/SerializablePrincipal.java?r1=607596&r2=607595&pathrev=607596



Mark Thomas wrote:
> fhanik@apache.org wrote:
>   
>> +  -1: fhanik - lets not do e.printStackTrace, handle the error and log it correctly,
>>     
>
> Fair point. I'll fix that.
>
> also, have the diff only change lines that are actually changed. makes it
> easier to review
>
> Which lines do you mean? The diff looks normal to me.
>
> Mark
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message