tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fha...@apache.org
Subject svn commit: r613209 - in /tomcat/tc6.0.x/trunk: STATUS.txt java/org/apache/catalina/tribes/membership/MemberImpl.java webapps/docs/changelog.xml
Date Fri, 18 Jan 2008 17:29:13 GMT
Author: fhanik
Date: Fri Jan 18 09:29:08 2008
New Revision: 613209

URL: http://svn.apache.org/viewvc?rev=613209&view=rev
Log:
add new feature

Modified:
    tomcat/tc6.0.x/trunk/STATUS.txt
    tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
    tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=613209&r1=613208&r2=613209&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Jan 18 09:29:08 2008
@@ -31,14 +31,9 @@
   +1: jfclere
   -1: fhanik - Can we add the 'package' directive to make the package match the dir structure
 
-* Add global flag to turn off reverse DNS lookups, performance improvement for tribes
-  http://svn.apache.org/viewvc?view=rev&revision=612192
-  +1: fhanik, markt, pero
-  -1: 
-
 * Update: native to 1.1.12; commons-pool to 1.4; commons archive locations.
   http://svn.apache.org/viewvc?rev=612950&view=rev
-  +1: markt, remm
+  +1: markt, remm, fhanik
   -1:
   
 * Add ManagerBase session getLastAccessedTimestamp and getCreationTimestamp for better

Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java?rev=613209&r1=613208&r2=613209&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/membership/MemberImpl.java Fri Jan
18 09:29:08 2008
@@ -37,6 +37,11 @@
 public class MemberImpl implements Member, java.io.Externalizable {
 
     /**
+     * Should a call to getName or getHostName try to do a DNS lookup?
+     * default is false
+     */
+    public static final boolean DO_DNS_LOOKUPS = Boolean.parseBoolean(System.getProperty("org.apache.catalina.tribes.dns_lookups","false"));
+    /**
      * Public properties specific to this implementation
      */
     public static final transient String TCP_LISTEN_PORT = "tcpListenPort";
@@ -430,7 +435,10 @@
         if ( this.hostname != null ) return hostname;
         else {
             try {
-                this.hostname = java.net.InetAddress.getByAddress(host).getHostName();
+                if (DO_DNS_LOOKUPS)
+                    this.hostname = java.net.InetAddress.getByAddress(host).getHostName();
+                else 
+                    this.hostname = org.apache.catalina.tribes.util.Arrays.toString(host);
                 return this.hostname;
             }catch ( IOException x ) {
                 throw new RuntimeException("Unable to parse hostname.",x);

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=613209&r1=613208&r2=613209&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Jan 18 09:29:08 2008
@@ -96,7 +96,8 @@
   </subsection>
   <subsection name="Catalina">
     <changelog>
-       <fix>
+      <update>Add -Dorg.apache.catalina.tribes.dns_lookups=false as default. The ability
to turn off reverse DNS lookups for membership.(fhanik)</update>
+      <fix>
          Set correct StandardManager.sessionCounter after reload/restart. (pero)
       </fix>
       <fix>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message