tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r604267 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
Date Sat, 15 Dec 2007 15:21:02 GMT
Done (switching back).

Mladen Turk schrieb:
> rjung@apache.org wrote:
>> Author: rjung
>>  int ajp_connect_to_endpoint(ajp_endpoint_t * ae, jk_logger_t *l)
>>  {
>> @@ -841,7 +861,7 @@
>>  
>>      if (!IS_VALID_SOCKET(ae->sd)) {
>>          ae->last_errno = errno;
>> -        jk_log(l, JK_LOG_INFO,
>> +        jk_log(l, JK_LOG_ERROR,
>>                 "Failed opening socket to (%s) (errno=%d)",
>>                 jk_dump_hinfo(&ae->worker->worker_inet_addr, buf),
>> ae->last_errno);
> 
> IMO this will create duplicate errors lines in the log for the
> same cause. The parent function calling this one will log the error
> if this one fails. Now we'll have multiple of them.
> 
> I've changed the ERROR->INFO some time back just because of that.
> Is it really needed to have that changed to ERROR?
> It'll only confuse users thought.
> 
> Regards,
> Mladen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message