Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: domain of jfclere@gmail.com designates
 66.249.92.168 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=Kw+lgXnbC80p/eP/1A72DfaWDY+0Pkylbr53Acy1smyYfN22OTNED52pG4l0DLhOeEUzMiGnZEziKvqqnnZ7/w3sjFL+OJNzHqELlvsGOXuqSdxpYwyIgjaDT2OHQmxakyQUrLwkpReoeVhYSMoVv1K2YGJzGfuhhd+cUGrwuFQ=
Message-ID: <474AABDD.7030006@gmail.com>
Date: Mon, 26 Nov 2007 12:19:57 +0100
From: jean-frederic clere <jfclere@gmail.com>
User-Agent: Thunderbird 2.0.0.9 (X11/20071115)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r596761 - in /tomcat/tc6.0.x/trunk: ./
 java/org/apache/catalina/core/
 java/org/apache/catalina/startup/ java/org/apache/tomcat/util/net/ res/
References: <20071120181902.B2B4A1A9832@eris.apache.org>
In-Reply-To: <20071120181902.B2B4A1A9832@eris.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

jim@apache.org wrote:
> Author: jim
> Date: Tue Nov 20 10:19:00 2007
> New Revision: 596761
> 
> URL: http://svn.apache.org/viewvc?rev=596761&view=rev
> Log:
> Fix BZ 43588 - hard coded 127.0.0.1 for localhost
> 
> Modified:
>     tomcat/tc6.0.x/trunk/STATUS.txt
>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java
>     tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
>     tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
>     tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/BaseEndpoint.java
>     tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/JIoEndpoint.java
>     tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/NioEndpoint.java
>     tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/PoolTcpEndpoint.java
>     tomcat/tc6.0.x/trunk/res/tomcat.nsi
> 

> Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java
> URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java?rev=596761&r1=596760&r2=596761&view=diff
> ==============================================================================
> --- tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java (original)
> +++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/startup/Catalina.java Tue Nov 20 10:19:00 2007
> @@ -24,6 +24,7 @@
>  import java.io.IOException;
>  import java.io.InputStream;
>  import java.io.OutputStream;
> +import java.net.InetAddress;
>  import java.net.Socket;
>  import java.util.ArrayList;
>  import java.util.HashMap;
> @@ -416,7 +417,8 @@
>  
>          // Stop the existing server
>          try {
> -            Socket socket = new Socket("127.0.0.1", server.getPort());
> +            String hostAddress = InetAddress.getByName("localhost").getHostAddress();
> +            Socket socket = new Socket(hostAddress, server.getPort());

Why not using Socket socket = new Socket("localhost", server.getPort()); ?

Cheers

Jean-Frederic

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org