Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 79232 invoked from network); 12 Nov 2007 15:54:03 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 12 Nov 2007 15:54:03 -0000 Received: (qmail 56942 invoked by uid 500); 12 Nov 2007 15:53:47 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 56903 invoked by uid 500); 12 Nov 2007 15:53:46 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 56892 invoked by uid 500); 12 Nov 2007 15:53:46 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 56889 invoked by uid 99); 12 Nov 2007 15:53:46 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Nov 2007 07:53:46 -0800 X-ASF-Spam-Status: No, hits=-100.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 12 Nov 2007 15:54:35 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id C86481A9832; Mon, 12 Nov 2007 07:53:27 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r594192 - /tomcat/tc6.0.x/trunk/STATUS Date: Mon, 12 Nov 2007 15:53:26 -0000 To: tomcat-dev@jakarta.apache.org From: fhanik@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20071112155327.C86481A9832@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: fhanik Date: Mon Nov 12 07:53:22 2007 New Revision: 594192 URL: http://svn.apache.org/viewvc?rev=594192&view=rev Log: proposing a third fix, still need to validate the value for escaping Modified: tomcat/tc6.0.x/trunk/STATUS Modified: tomcat/tc6.0.x/trunk/STATUS URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=594192&r1=594191&r2=594192&view=diff ============================================================================== --- tomcat/tc6.0.x/trunk/STATUS (original) +++ tomcat/tc6.0.x/trunk/STATUS Mon Nov 12 07:53:22 2007 @@ -51,15 +51,20 @@ and $Version parsing +1: jfclere, pero -1: markt - only the double quoting part - see http://marc.info/?l=tomcat-dev&m=119454915422424&w=2 for reasons - -1: fhanik - proposed patch http://people.apache.org/~fhanik/patches/cookies-fix.patch - -* Alternate Cookies fix - http://people.apache.org/~fhanik/patches/cookies-fix-2.patch - Includes: Version fix, Escape fix - Excludes: Already quoted fix, vetoed in prev proposal - +1: fhanik - -1: jfclere TC doesn't pass TCK tests with your patch. +1 for the version part. + -1: fhanik - proposed patch below * Fix licensing of JSP 2.1 schema svn diff -c r593814 +1: markt, remm, jfclere -1: + +* Fix cookie parsing, rev 3 + Includes: Version fix, Escape fix, already quoted fix + It seems that the TCK doesn't do a good job at knowing what an escape character is. + Since the TCK does set an "already quoted" value, we should assume that that is how they interpret the cookie handling in the servlet spec + In this fix however, alreadyQuoted also checks for escaped values, and ignores them + http://people.apache.org/~fhanik/patches/cookies-fix-3.patch + +1: fhanik + -1: + + \ No newline at end of file --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org