tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mladen Turk <mt...@apache.org>
Subject Re: VirtualHost inheritance (was Re: [Bug 43753] ...)
Date Fri, 02 Nov 2007 08:25:23 GMT
Rainer Jung wrote:
> Hi,
> 
> be careful:

OK :)

> 
> I also added an option JkMountCopyAll,

OK, but clone is called when there is no "JkMountCopy All" defined
if (sconf && sconf->was_initialized == JK_TRUE && jk_mount_copy_all ==
JK_FALSE) {
	clone_jk_config

So if there is *no* module directives and JkMountCopy All is not defined
the clone_jk_config is still called (without mounts but with copied
envvars).


> which automatically puts a
> JkMountCopy into every vhost and saves memory, because we then do not
> clone but instead share the config struct (if no other jk directives are
> in the vhost).

But they use different apr_pools with different lifetime, so that might
be the problem later. Cloned configs although allocated don't register
pool cleanup

Anyhow the envvar tables should be NULLed in clone, cause
merge will later concatenate them for each vhost.

Regards,
Mladen.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message