tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: VirtualHost inheritance (was Re: [Bug 43753] ...)
Date Fri, 02 Nov 2007 08:07:20 GMT
Hi,

be careful: I added clone after 1.2.25 exaxctly because of the problem,
that the Apache API doesn't call the config create callback for a vhost,
if the vhost contains no config directives for some module.

In our situation we have the following assumptions:

- we don't want to automatically inherit JkMounts between vhosts.
  That's documented and usually what you want. Content can be very
difficult between vhosts.
- we need a separate config structure for every vhost

This is why I introduced the clone. It's a copy without the mounts.

I also added an option JkMountCopyAll, which automatically puts a
JkMountCopy into every vhost and saves memory, because we then do not
clone but instead share the config struct (if no other jk directives are
in the vhost).

Although I thought I had it fixed and tested, Jean-Frederic found a bug
with was_initialized which lets me think, that I got the "we already
initialized this vhost" markers wrong. It is still open for me to do the
final cleanup (correct markers for initialized state and cloned state)
and I might have an hour today to do so.

Regards,

Rainer

Mladen Turk schrieb:
> Ian Ward Comfort wrote:
>>
>> I don't know if this is intended behavior, or a bug in mod_jk, or even
>> a bug in Apache, but something seems amiss.  Thoughts?
>>
> 
> Your patch won't work.
> The real problem is in the initialization for vhosts where
> when there is *any* Jk directive the create_jk_config is called
> while where there isn't the clone_jk_config is called.
> 
> clone_jk_config is bogus, and doesn't behave like it should
> (copy only the basic data and no mounts)
> 
> Regards,
> Mladen

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message