Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (athena.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.3)
Content-Transfer-Encoding: quoted-printable
Message-Id: <0280414F-5E43-465E-BB93-80D30A292633@objektpark.de>
Content-Type: text/plain; charset=ISO-8859-1; delsp=yes; format=flowed
To: Tomcat Developers List <dev@tomcat.apache.org>
From: Peter Rossbach <pr@objektpark.de>
Subject: Call stopAwait at StandardServer.stop
Date: Sun, 7 Oct 2007 10:35:00 +0200

Hi,

I have reviewed Catalina and StandardServer Tomcat 6 implementation. =20
I can see that the old trick with <Server port=3D"-1" ... doesn=B4t work =
=20
correct. The main thread is not terminate after a stop signal was =20
received.

With port=3D-1 setting a user can start a tomcat without opening a =20
shutdown port.  Ok, the only chance to stop a tomcat instance
is to send a signal to the jvm process, but the stopAwait flag at =20
StandardServer doesn't trigger.

Catalina.stop ...
         // Shut down the server
         if (server instanceof Lifecycle) {
             try {
                 ((Lifecycle) server).stop();
             } catch (LifecycleException e) {
                 log.error("Catalina.stop", e);
             }
         }

calls only StandardServer stop, but stop doesn't trigger the =20
stopAwait flag

     public void stop() throws LifecycleException {

         // Validate and update our current component state
         if (!started)
             return;

         // Notify our interested LifecycleListeners
         lifecycle.fireLifecycleEvent(BEFORE_STOP_EVENT, null);

         lifecycle.fireLifecycleEvent(STOP_EVENT, null);
         started =3D false;

         // Stop our defined Services
         for (int i =3D 0; i < services.length; i++) {
             if (services[i] instanceof Lifecycle)
                 ((Lifecycle) services[i]).stop();
         }

         // Notify our interested LifecycleListeners
         lifecycle.fireLifecycleEvent(AFTER_STOP_EVENT, null);

     }

can we please fix it:

     public void stop() throws LifecycleException {

         // Validate and update our current component state
         if (!started)
             return;

         // Notify our interested LifecycleListeners
         lifecycle.fireLifecycleEvent(BEFORE_STOP_EVENT, null);

         lifecycle.fireLifecycleEvent(STOP_EVENT, null);
         started =3D false;

         // Stop our defined Services
         for (int i =3D 0; i < services.length; i++) {
             if (services[i] instanceof Lifecycle)
                 ((Lifecycle) services[i]).stop();
         }
	// =3D=3D=3D=3D=3D=3D FIX BEGIN
	if(port =3D=3D -1)
		stopAwait() ;
        // =3D=3D=3D=3D=3D=3D END
         // Notify our interested LifecycleListeners
         lifecycle.fireLifecycleEvent(AFTER_STOP_EVENT, null);

     }

I think we can also backport it to Tomcat 5.5 trunk

regards
Peter


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org