tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jean-frederic clere <jfcl...@gmail.com>
Subject Re: svn commit: r583858 - /tomcat/tc6.0.x/trunk/STATUS
Date Fri, 12 Oct 2007 09:18:37 GMT
Filip Hanik - Dev Lists wrote:
> to be clear, let me address your statements
> 
> remm -1: removes support for the production APR connectors
> Absolutely not, doesn't change the way connectors are evaluated.
> 
> remm -1: no real benefit of the patch
> The NIO connector attributes are now supported, the implementation is
> simpler and more flexible, and can be expanded to other components not
> supported today

I think I will -1:
There is the following in
java/org/apache/tomcat/util/IntrospectionUtils.java
+++
            if (setPropertyMethod != null) {
                Object params[] = new Object[2];
                params[0] = name;
                params[1] = value;
                setPropertyMethod.invoke(o, params);
                return true;
            }
+++
Can't we try to check the Object returned by setPropertyMethod.invoke
and set the return code according to the value of the Object?

Cheers

Jean-Frederic


> furthermore, there are no exception cases anymore, like the
> o.a.c.connector.Connector object, is treated same way as before
> 
> Filip
> 
> Filip Hanik - Dev Lists wrote:
>> the patch doesn't change the behavior for the APR connector, can you
>> please explain what you mean?
>> apply the patch, try it out on your APR connector, and it should work
>> just like before
>> Filip
>>
>> remm@apache.org wrote:
>>> Author: remm
>>> Date: Thu Oct 11 08:44:34 2007
>>> New Revision: 583858
>>>
>>> URL: http://svn.apache.org/viewvc?rev=583858&view=rev
>>> Log:
>>> - Vote.
>>>
>>> Modified:
>>>     tomcat/tc6.0.x/trunk/STATUS
>>>
>>> Modified: tomcat/tc6.0.x/trunk/STATUS
>>> URL:
>>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=583858&r1=583857&r2=583858&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>>> +++ tomcat/tc6.0.x/trunk/STATUS Thu Oct 11 08:44:34 2007
>>> @@ -50,4 +50,4 @@
>>>  * to accept or reject the property
>>>   
>>> http://people.apache.org/~fhanik/patches/digester-attribute-warnings.patch
>>>
>>>    +1: fhanik
>>> -  -1: +  -1: remm (removes support for the production APR
>>> connectors, no real benefit of the patch)
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>>   
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message