tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r582597 - /tomcat/tc6.0.x/trunk/STATUS
Date Mon, 08 Oct 2007 16:26:20 GMT
since the STATUS file is also a voting forum, there must be a reference 
to an absolute patch/diff. otherwise, the implementation can change 
during the voting phase.
so what I suggest you do is

1. create a .patch file, with your proposed solution
2. upload it to your /home/pero/public_html/patches/ directory
3. put the URL reference to the .patch file in the STATUS file

this seems to work pretty well, and that is what we've been doing
the other option, is to open a BZ item, attach your patch in there

Filip

Peter Rossbach wrote:
> OK!
>
> How we can easier promote and discuss those patches? You are right, an 
> email threads are not easy to reference at STATUS file. Arrg!
> I  don't think that the apache developer home folder are the right 
> place for those patches!
>
> Open a bug report for every possible change is also not a good 
> solution. But other people can
> add there comments and ideas.
>
> Every hint to a standard procedure?
>
> Peter
>
> PS: Can we move the tomcat 5.5 STATUS file to the build project? Then 
> it was easier for me to change the file at my eclipse.
>
>
> Am 08.10.2007 um 17:13 schrieb Filip Hanik - Dev Lists:
>
>> I did, but folks shouldn't have to dig through the dev archives, 
>> should they :)
>>
>> Filip
>>
>> Peter Rossbach wrote:
>>> Hi Filip,
>>>
>>> has you seen my "Call stopAwait at StandardServer.stop" mail?
>>>
>>> Peter
>>>
>>>
>>> Am 07.10.2007 um 17:10 schrieb Filip Hanik - Dev Lists:
>>>
>>>> don't forget to include a link to the diff file, so that it can be 
>>>> reviewed before committed, just in case someone misses the dev email
>>>>
>>>> Filip
>>>>
>>>> pero@apache.org wrote:
>>>>> Author: pero
>>>>> Date: Sun Oct  7 01:36:51 2007
>>>>> New Revision: 582597
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=582597&view=rev
>>>>> Log:
>>>>> add change request: call StandardServer stopAwait
>>>>>
>>>>> Modified:
>>>>>     tomcat/tc6.0.x/trunk/STATUS
>>>>>
>>>>> Modified: tomcat/tc6.0.x/trunk/STATUS
>>>>> URL: 
>>>>> http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS?rev=582597&r1=582596&r2=582597&view=diff

>>>>>
>>>>> ==============================================================================

>>>>>
>>>>> --- tomcat/tc6.0.x/trunk/STATUS (original)
>>>>> +++ tomcat/tc6.0.x/trunk/STATUS Sun Oct  7 01:36:51 2007
>>>>> @@ -44,4 +44,7 @@
>>>>>    update to 
>>>>> jdt.loc=http://sunsite.informatik.rwth-aachen.de/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip

>>>>>
>>>>>    +1: pero
>>>>>    -1: -  \ No newline at end of file
>>>>> +
>>>>> +* Call StopAwait at StandardServer.stop as port==-1
>>>>> +  +1: pero
>>>>> +  -1:
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>
>
> ------------------------------------------------------------------------
>
> No virus found in this incoming message.
> Checked by AVG Free Edition. 
> Version: 7.5.488 / Virus Database: 269.14.4/1056 - Release Date: 10/7/2007 6:12 PM
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message