tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: Time to organise svn
Date Fri, 05 Oct 2007 17:11:13 GMT
jean-frederic clere wrote:
> Filip Hanik - Dev Lists wrote:
>   
>> jean-frederic clere wrote:
>>     
>>> Filip Hanik - Dev Lists wrote:
>>>  
>>>       
>>>> Remy Maucherat wrote:
>>>>    
>>>>         
>>>>> jean-frederic clere wrote:
>>>>>      
>>>>>           
>>>>>> Remy Maucherat wrote:
>>>>>>        
>>>>>>             
>>>>>>> Mark Thomas wrote:
>>>>>>>          
>>>>>>>               
>>>>>>>> Next attempt.
>>>>>>>>
>>>>>>>> Taking account of the comments so far, a slightly modified
>>>>>>>> proposal is
>>>>>>>> below.
>>>>>>>>
>>>>>>>> svn cp https://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk
>>>>>>>> https://svn.apache.org/repos/asf/tomcat/trunk
>>>>>>>>
>>>>>>>> svn cp
>>>>>>>> https://svn.apache.org/repos/asf/tomcat/tc6.0.x/tags/TOMCAT_6_0_14
>>>>>>>> https://svn.apache.org/repos/asf/tomcat/tc6.1.0/trunk
>>>>>>>>             
>>>>>>>>                 
>>>>>>> Instead, I would propose to tag a new 6.0.15 candidate first.
>>>>>>>           
>>>>>>>               
>>>>>> That is also what I proposed in my previous comment.
>>>>>>         
>>>>>>             
>>>>> Didn't see it, sorry. I propose tagging a 6.0.15 candidate on Monday.
>>>>>       
>>>>>           
>>>> Can we wait a bit, there are a few bug fixes that need to be caught up
>>>> on , and I also think we can improve upon the server.xml invalid
>>>> attribute implementation, the way I did the sandbox. I'll come up withe
>>>> patches for the bug
>>>>     
>>>>         
>>> What is the PR number?
>>>   
>>>       
>> BZ 43478
>> http://svn.apache.org/viewvc?rev=581384&view=rev
>>     
>
> +1 For this one.
>
> The stuff below I am -1 until more explanations.
>   
it's a continuation of the 6.0 fix, based on the same code, but instead 
of treating connectors like an exception case, it removes the exception 
case and treats all components equal.
further more, it allows components with nested properties to set their 
own rules, by doing the "boolean setProperty" instead of "void 
setProperty". Of course, the old way is 100% backwards compatible.
> BTW: The comment of 581431 is "weird" no?
>   
its a comment towards myself as I had to mess around some 'til I finally 
got it right. you should have seen my first attempt (never showed in 
SVN), but that was a debacle :)
> What PR does it fix?
>   
same as 6.0, but more flexibility, and less exception cases. adds the 
NIO connector, and adds consistency to the warning messages

Filip
> Cheers
>
> Jean-Frederic
>
>   
>> http://svn.apache.org/viewvc?rev=581422&view=rev
>> http://svn.apache.org/viewvc?rev=581431&view=rev
>>
>> Filip
>>
>>     
>>> Cheers
>>>
>>> Jean-Frederic
>>>
>>>  and the fixes for the invalid attribute thingy, and
>>>  
>>>       
>>>> put them in the status file
>>>>
>>>> Filip
>>>>    
>>>>         
>>>>> Rémy
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>>
>>>>>
>>>>>
>>>>>       
>>>>>           
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>>     
>>>>         
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>>
>>>   
>>>       
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>>
>>     
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>
>   


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message