Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <46F8A9E1.4060708@kippdata.de>
Date: Tue, 25 Sep 2007 08:25:37 +0200
From: Rainer Jung <rainer.jung@kippdata.de>
User-Agent: Thunderbird 2.0.0.6 (X11/20070802)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: 6.0.x request processing patch
References: <200709241941.l8OJf1Lr002457@maui.wilshire.com>
 <46F81E8D.1080309@hanik.com>
In-Reply-To: <46F81E8D.1080309@hanik.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

Hi Filip,

I guess that also fixes the misleading html manager display (request 
times going up and up). That would be very nice.

Just a quick shot:

- maybe you can fix Procssing -> Processing everywhere

- will this change the behaviour of the requestProcessingTime as one can 
retrieve from the MBeans of the GlobalRequestProcessor or Servlets? I 
guess (and hope) no?

- lastRequestProcssingTime: This item is new but apart from the new 
setter and getter not used, especially not in the 
getRequestProcessingTime fix. If this data is needed, shouldn't we also 
expose it via the mbean descriptor? It's nice for a statistic sampling 
of response times.

Regards,

Rainer

Filip Hanik - Dev Lists wrote:
> here is the modified patch
> 
> Filip
> 
> Bill Barker wrote:
>> I would think that using the stage would be more reliable than hacking 
>> the
>> startTime, but otherwise, I have no strong opinion either way.
>>  
>>> -----Original Message-----
>>> From: Filip Hanik - Dev Lists [mailto:devlists@hanik.com] Sent: 
>>> Monday, September 24, 2007 11:49 AM
>>> To: Tomcat Developers List
>>> Subject: 6.0.x request processing patch
>>>
>>> Currently, the RequestInfo.getRequestProcessingTime is not taking 
>>> into account if the request is active or not, hence returning a 
>>> larger and larger value if a new request is not received.
>>> The patch addresses the following
>>>
>>> 1. getRequestProcessingTime returns 0 if no request is active
>>> 2. getLastRequestProcessingTime will return the time for the last 
>>> request
>>>
>>> Does anyone think the values that are returned should be different?
>>> thoughts?
>>> Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org