Return-Path: 
 <dev-return-83547-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org>
Delivered-To: apmail-tomcat-dev-archive@www.apache.org
Received: (qmail 46874 invoked from network); 13 Sep 2007 17:45:01 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 13 Sep 2007 17:45:01 -0000
Received: (qmail 62606 invoked by uid 500); 13 Sep 2007 17:44:51 -0000
Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org
Received: (qmail 62571 invoked by uid 500); 13 Sep 2007 17:44:51 -0000
Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@tomcat.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@tomcat.apache.org>
List-Post: <mailto:dev@tomcat.apache.org>
List-Id: <dev.tomcat.apache.org>
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Delivered-To: mailing list dev@tomcat.apache.org
Received: (qmail 62560 invoked by uid 99); 13 Sep 2007 17:44:51 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Sep 2007 10:44:51 -0700
X-ASF-Spam-Status: No, hits=-0.0 required=10.0
	tests=SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: local policy)
Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Sep 2007 17:46:29 +0000
Received: (qmail 26068 invoked from network); 13 Sep 2007 12:42:53 -0500
Received: from 72-19-171-38.static.mesanetworks.net (HELO ?192.168.3.103?)
 (72.19.171.38)
  by halosg.com with SMTP; 13 Sep 2007 12:42:53 -0500
Message-ID: <46E976FA.5080707@hanik.com>
Date: Thu, 13 Sep 2007 11:44:26 -0600
From: Filip Hanik - Dev Lists <devlists@hanik.com>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r575332 - in /tomcat/tc6.0.x/trunk:
 java/org/apache/naming/resources/FileDirContext.java
 webapps/docs/changelog.xml
References: <20070913152000.5FD6C1A9832@eris.apache.org>
 <46E9565B.2060108@apache.org>
In-Reply-To: <46E9565B.2060108@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org

Remy Maucherat wrote:
> funkman@apache.org wrote:
>> Author: funkman
>> Date: Thu Sep 13 08:19:59 2007
>> New Revision: 575332
>>
>> URL: http://svn.apache.org/viewvc?rev=575332&view=rev
>> Log:
>> Allow for Aliases at the resource level.
>> This is to prevent situations of relying on symlinks, or Filters 
>> while still make outside directories appear as part of the webapp. (A 
>> common feature request seen on the user list)
>> Example usage:
>> <Context ... >
>>   <Resources className="org.apache.naming.resources.FileDirContext"
>>                aliases="/doh/=C:/tmp/woohoo/,
>>                         /mmmmmm/=C:/opt/data/doughnuts/" />
>> </Context>
>>
>> If the feature is NOT used - there is no additional overhead.
>
> The reasonable thing would have been to talk a bit about it. I think 
> using a subclass (assuming you really want to put this in, which I 
> don't really like - small euphemism) would be more reasonable.
oh brother, let go of the control, it's not your code base.
>
> Since you did not do any of this, I will have to veto this patch.
based on what?

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org