tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <>
Subject Re: Review model take 2
Date Thu, 20 Sep 2007 02:43:34 GMT
Bill Barker wrote:
> Remy was being really nice to the community by not requiring a vetoed patch 
> to be withdrawn.  Personally, I would go with j-f-c's position, and withdraw 
> a vetoed patch immediately (and have done so on several occations, even when 
> I got to re-apply it after enough discussion took place on the list). 
> However, I'll go with whatever the community consensus is on this point.

But isn't that statement too broad (to apply to trunk, I agree that in a
ready-to-release anytime sort of branch, disputed things should disappear
for a while)...

It's in the context.  If Joe suggests "hey, -1 to the way you presented
that, if you fix X you have my support" then it should stick a round a
while and let them sort it out.

If Joe says "this feature isn't going to be acceptable because Y", well
then there isn't much to discuss at that point, and it probably should be
backed out right away while the basic idea is debated.

Clear A/B options sometimes aren't that effective.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message