Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Mime-Version: 1.0 (Apple Message framework v752.2)
In-Reply-To: <46B9EAD1.9090102@kippdata.de>
References: <20070802174224.A6FA01A981D@eris.apache.org>
 <9645DC78-4315-45A4-B16B-D10B84982844@jaguNET.com>
 <46B23EC5.7070401@kippdata.de>
 <26FF658D-B877-493B-AC38-7F9DFB8D5726@jaguNET.com>
 <46B9EAD1.9090102@kippdata.de>
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <C66D473B-F775-4683-AE20-F58735C00668@jaguNET.com>
Content-Transfer-Encoding: 7bit
From: Jim Jagielski <jim@jaguNET.com>
Subject: Re: svn commit: r562194 - in /tomcat/connectors/trunk/jk:
 native/common/jk_ajp13.h
 native/common/jk_ajp_common.c		 native/common/jk_lb_worker.c
 xdocs/miscellaneous/changelog.xml xdocs/reference/workers.xml
Date: Wed, 8 Aug 2007 12:25:29 -0400
To: "Tomcat Developers List" <dev@tomcat.apache.org>

:)

It just seemed like a conscious coding style and didn't want
to confuse things...

Or else it was some normal C array/pointer confusion :)
*duck*

On Aug 8, 2007, at 12:09 PM, Rainer Jung wrote:

> You are missing nothing. Feel free to scratch :)
>
> Regards,
>
> Rainer
>
> Jim Jagielski wrote:
>> On Aug 2, 2007, at 4:29 PM, Rainer Jung wrote:
>>> And in fact it doesn't matter. I found it more logical, to have  
>>> JK_STATUS_ERROR and JK_STATUS_FATAL_ERROR closer together (for  
>>> those reading the code). The constants are not used outside JK,  
>>> so there is no compatibility problem.
>>>
>>> It looks like your are closely following todays JK changes. I  
>>> really appreciate that! Unless you find problems, I just now  
>>> commited my last change (hopefully) for 1.2.25.
>> A other little nit: The see a few places where
>> we have things like (in jk_lb_worker.c for example):
>>    &(p->lb_workers[0].s->route[0])
>> Can't they simply be reduced to
>>    p->lb_workers[0].s->route
>> ?
>> Not exactly sure what I'm missing there...
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org