Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 24698 invoked from network); 1 Sep 2007 02:57:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Sep 2007 02:57:09 -0000 Received: (qmail 29760 invoked by uid 500); 1 Sep 2007 02:56:58 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 29696 invoked by uid 500); 1 Sep 2007 02:56:58 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 29685 invoked by uid 99); 1 Sep 2007 02:56:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 31 Aug 2007 19:56:58 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 01 Sep 2007 02:56:53 +0000 Received: (qmail 29935 invoked from network); 31 Aug 2007 21:55:34 -0500 Received: from 72-19-171-38.static.mesanetworks.net (HELO ?192.168.3.103?) (72.19.171.38) by halosg.com with SMTP; 31 Aug 2007 21:55:34 -0500 Message-ID: <46D8D4E3.5000609@hanik.com> Date: Fri, 31 Aug 2007 20:56:35 -0600 From: Filip Hanik - Dev Lists User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r571578 - in /tomcat/trunk/java/org/apache: catalina/CometEvent.java catalina/connector/CometEventImpl.java catalina/connector/Request.java coyote/http11/Http11NioProcessor.java tomcat/util/net/PollerInterest.java References: <20070831205902.29CF11A9832@eris.apache.org> <46D8AD7F.3050209@apache.org> In-Reply-To: <46D8AD7F.3050209@apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org Remy Maucherat wrote: > fhanik@apache.org wrote: >> Author: fhanik >> Date: Fri Aug 31 13:59:00 2007 >> New Revision: 571578 >> >> URL: http://svn.apache.org/viewvc?rev=571578&view=rev >> Log: >> Move back to original idea, use primitive int instead of enum, >> extremely inefficient using enums and arrays to hold them. > > Good. Two of the biggest gropes I had in this portion of the API and > impl are now gone (after arguing they were great ideas, and ignoring > my complaints about them for months :( ). pardon me, I always wanted the int, you were arguing the enums, so I compromised. then I realized how bad it was, so I took it out. > How about adopting my interface ? It's clearly the next step in the > evolution. don't like that interface, but a simple vote will resolve the dispute. > > The main problem continues, though: API changes are being made without > being discussed in any way beforehand. I think this needs to stop, and > I will restart the vote for moving this branch to the sandbox. you slandered several people in the last vote thread without really answering any of their questions, don't see the point of another one vote, since you bowed out of the real questions in the last one. The vote should be, and should have always been, about the API. Filip > > Rémy > > PS: The fix for the close problem is horrible, but good job on finding > the bug. you've already refused to acknowledge this bug a long time ago, when it was first brought up, wonder what changed your mind > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org