tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henri Gomez" <henri.go...@gmail.com>
Subject Re: svn commit: r567689 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
Date Tue, 21 Aug 2007 07:27:31 GMT
The define told us that we shouldn't use flush on AS400 V5R2 and previous.

On V5R4 (UTF8 mode), we could use it.

This code (no flush) is pretty old and was provided by i5/OS IBM Labs,
so better stick with it. On V5R3 and previous release, we didn't see
the send_bodyct was probably set another way.

The question may be should we keep the i5/OS version for pre V5R4 ?

2007/8/20, Rainer Jung <rainer.jung@kippdata.de>:
> Hi Henri,
>
> so now i5/OS should use send_bodyct like the other platforms. What I
> don't understand is:
>
> hgomez@apache.org wrote:
> > @@ -375,7 +369,7 @@
> >
> >  static void JK_METHOD ws_flush(jk_ws_service_t *s)
> >  {
> > -#ifndef AS400
> > +#if ! (defined(AS400) && !defined(AS400_UTF8))
> >      if (s && s->ws_private) {
> >          apache_private_data_t *p = s->ws_private;
> >          ap_rflush(p->r);
> > @@ -423,7 +417,7 @@
> >                  }
> >              }
> >              if (p->r->header_only) {
> > -#ifndef AS400
> > +#if ! (defined(AS400) && !defined(AS400_UTF8))
> >                  ap_rflush(p->r);
> >  #endif
> >                  return JK_TRUE;
>
>
> This looks like, if we have i5/OS and not UTF8, then we still won't use
> the flush. But without flush I think, that send_bodyct will not be set.
>
> Can't you simply call the ap_rflush() for that platform exactly the same
> way, as for the other platforms?
>
> Regards,
>
> Rainer
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message