tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r562022 - in /tomcat/connectors/trunk/jk: native/apache-1.3/mod_jk.c native/apache-2.0/mod_jk.c xdocs/miscellaneous/changelog.xml
Date Thu, 02 Aug 2007 09:15:58 GMT
Hi Mladen,

I don't full yunderstand this fix. From your other mail i though it's a 
regression, but the code in this region is the same at least since 
1.2.18 (more than a year). So I have the impression, that this is not a 
regression. If so, I would prefer to not push 1.2.25 through with very 
high speed, i.e. 1.2.24 would still be pretty useful as an update.

Regards,

Rainer

mturk@apache.org wrote:
> Author: mturk
> Date: Wed Aug  1 23:06:18 2007
> New Revision: 562022
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=562022
> Log:
> Fix the 401 not passed to the client.
> 
> Modified:
>     tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
>     tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
>     tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
> 
> Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?view=diff&rev=562022&r1=562021&r2=562022
> ==============================================================================
> --- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
> +++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Wed Aug  1 23:06:18 2007
> @@ -2159,7 +2159,8 @@
>              if (rc > 0) {
>                  /* If tomcat returned no body and the status is not OK,
>                     let apache handle the error code */
> -                if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST)
{
> +                if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST
&&
> +                     r->status != HTTP_UNAUTHORIZED) {
>                      jk_log(conf->log, JK_LOG_INFO, "No body with status=%d"
>                             " for worker=%s",
>                             r->status, worker_name);
> 
> Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=562022&r1=562021&r2=562022
> ==============================================================================
> --- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
> +++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Wed Aug  1 23:06:18 2007
> @@ -2250,7 +2250,8 @@
>  
>  /* hgomez@20070516 : under i5/OS sent_bodyct is not set correctly */
>  /*                   check for header_only to see if there was a body */
> -                if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST)
{
> +                if (!r->sent_bodyct && r->status >= HTTP_BAD_REQUEST
&&
> +                     r->status != HTTP_UNAUTHORIZED) {
>                      jk_log(xconf->log, JK_LOG_INFO, "No body with status=%d"
>                             " for worker=%s",
>                             r->status, worker_name);
> 
> Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diff&rev=562022&r1=562021&r2=562022
> ==============================================================================
> --- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
> +++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Wed Aug  1 23:06:18
2007
> @@ -23,6 +23,16 @@
>    new documentation project for JK was started.
>    </p>
>  </section>
> +<section name="Changes between 1.2.24 and 1.2.25">
> +  <br />
> +  <subsection name="Native">
> +    <changelog>
> +      <fix>
> +        Pass the 401 as OK instead sending 401 for authentication. (mturk)
> +      </fix>
> +    </changelog>
> +  </subsection>
> +</section>
>  <section name="Changes between 1.2.23 and 1.2.24">
>    <br />
>    <subsection name="Native">

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message