tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From rj...@apache.org
Subject svn commit: r554568 - in /tomcat/container/tc5.5.x/webapps: docs/changelog.xml manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java
Date Mon, 09 Jul 2007 08:57:33 GMT
Author: rjung
Date: Mon Jul  9 01:57:31 2007
New Revision: 554568

URL: http://svn.apache.org/viewvc?view=rev&rev=554568
Log:
Don't write error on System.out, use log() instead.

Modified:
    tomcat/container/tc5.5.x/webapps/docs/changelog.xml
    tomcat/container/tc5.5.x/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=554568&r1=554567&r2=554568
==============================================================================
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Mon Jul  9 01:57:31 2007
@@ -52,6 +52,9 @@
   <subsection name="Webapps">
     <changelog>
       <fix>
+        Don't write error on System.out, use log() instead. (rjung)
+      </fix>
+      <fix>
         Fix XSS security vulnerabilities (CVE-2007-2449) in the examples.
         Reported by Toshiharu Sugiyama. (markt)
       </fix>

Modified: tomcat/container/tc5.5.x/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java
URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java?view=diff&rev=554568&r1=554567&r2=554568
==============================================================================
--- tomcat/container/tc5.5.x/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java
(original)
+++ tomcat/container/tc5.5.x/webapps/manager/WEB-INF/classes/org/apache/catalina/manager/JMXProxyServlet.java
Mon Jul  9 01:57:31 2007
@@ -175,8 +175,8 @@
                     try {
                         value=mBeanServer.getAttribute(oname, attName);
                     } catch( Throwable t) {
-                        System.out.println("Error getting attribute " + oname +
-                                " " + attName + " " + t.toString());
+                        log("Error getting attribute " + oname +
+                            " " + attName + " " + t.toString());
                         continue;
                     }
                     if( value==null ) continue;
@@ -216,7 +216,7 @@
 
     private void appendHead( StringBuffer sb, String value, int start, int end) {
         if (end < 1) return;
-        
+
         int pos=start;
         while( end-pos > 78 ) {
             sb.append( value.substring(pos, pos+78));



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message