Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 52838 invoked from network); 1 Jun 2007 08:20:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Jun 2007 08:20:21 -0000 Received: (qmail 84741 invoked by uid 500); 1 Jun 2007 08:20:22 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 84188 invoked by uid 500); 1 Jun 2007 08:20:20 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 84174 invoked by uid 99); 1 Jun 2007 08:20:20 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2007 01:20:20 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [207.113.241.148] (HELO iss04.interliant.com) (207.113.241.148) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2007 01:20:15 -0700 Received: from EX-008.mail.navisite.com (ex-008.interliant.com [207.113.240.188]) by iss04.interliant.com (8.10.2/8.10.2) with ESMTP id l518Jr507805 for ; Fri, 1 Jun 2007 03:19:53 -0500 (CDT) Received: from [192.168.0.168] ([89.164.19.205]) by EX-008.mail.navisite.com with Microsoft SMTPSVC(6.0.3790.1830); Fri, 1 Jun 2007 03:19:50 -0500 Message-ID: <465FD6A4.6010804@apache.org> Date: Fri, 01 Jun 2007 10:19:48 +0200 From: Mladen Turk User-Agent: Mozilla MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r543419 - /tomcat/connectors/trunk/jk/native/common/jk_util.c References: <20070601075353.EA9601A981A@eris.apache.org> In-Reply-To: <20070601075353.EA9601A981A@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-OriginalArrivalTime: 01 Jun 2007 08:19:50.0345 (UTC) FILETIME=[9FB3BB90:01C7A425] X-Virus-Checked: Checked by ClamAV on apache.org rjung@apache.org wrote: > Correct pthread_t casting in jk_gettid(). > Needed at least on Mac OS X, > shouldn't hurt on other platforms. > > - int tid = (int)(t & 0xFFFF); > + int tid = ((int)t) & 0xFFFF; Since thread id is a pointer, think it can even be rounded to the sizeof t Something like ((int)t / align(sizeof t)) & 0xffff Anyhow, it's used only for logging to have an idea from which threads in worker mpm's the logs are coming, so the accuracy is not important. Regards, Mladen. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org