Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 84326 invoked from network); 1 Jun 2007 14:43:46 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 1 Jun 2007 14:43:46 -0000 Received: (qmail 96058 invoked by uid 500); 1 Jun 2007 14:43:47 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 95730 invoked by uid 500); 1 Jun 2007 14:43:45 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 95719 invoked by uid 500); 1 Jun 2007 14:43:45 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 95716 invoked by uid 99); 1 Jun 2007 14:43:45 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2007 07:43:45 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Jun 2007 07:43:41 -0700 Received: by brutus.apache.org (Postfix, from userid 33) id E42A2714186; Fri, 1 Jun 2007 07:43:20 -0700 (PDT) From: bugzilla@apache.org To: tomcat-dev@jakarta.apache.org Subject: DO NOT REPLY [Bug 42497] - 304 response should consistently include ETag header In-Reply-To: X-Bugzilla-Reason: AssignedTo Message-Id: <20070601144320.E42A2714186@brutus.apache.org> Date: Fri, 1 Jun 2007 07:43:20 -0700 (PDT) X-Virus-Checked: Checked by ClamAV on apache.org DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG� RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND� INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bug.cgi?id=42497 ------- Additional Comments From len.popp@gmail.com 2007-06-01 07:43 ------- I see how to fix this, but I'm not set up to compile Tomcat so someone else will have to make the change and test it. In org.apache.catalina.servlets.DefaultServlet, the serveResource method sets an ETag header when it serves a file with a 200 or 206 response. To get it to add the ETag to 304 responses, this needs to be added: response.setHeader("ETag", getETag(resourceAttributes)); in two places where a a status of 304 (SC_NOT_MODIFIED) is set, in the methods checkIfModifiedSince and checkIfNoneMatch. -- Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug, or are watching the assignee. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org