tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42497] - 304 response should consistently include ETag header
Date Fri, 01 Jun 2007 14:43:20 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42497>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42497





------- Additional Comments From len.popp@gmail.com  2007-06-01 07:43 -------
I see how to fix this, but I'm not set up to compile Tomcat so someone else will
have to make the change and test it.

In org.apache.catalina.servlets.DefaultServlet, the serveResource method sets an
ETag header when it serves a file with a 200 or 206 response. To get it to add
the ETag to 304 responses, this needs to be added:
 response.setHeader("ETag", getETag(resourceAttributes));
in two places where a a status of 304 (SC_NOT_MODIFIED) is set, in the methods
checkIfModifiedSince and checkIfNoneMatch.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message