tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Peter Rossbach ...@objektpark.de>
Subject Re: svn commit: r544401 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/mbeans/JMXAdaptorLifecycleListener.java webapps/docs/changelog.xml webapps/docs/monitoring.xml
Date Tue, 12 Jun 2007 05:23:30 GMT
HI,

good point :-)
I think we can build with JDK 1.5 and save the classes files at 1.4  
format.
We can do that with the ant javac option <javac ... target="1.4">.  
What we need is a new compile.target=1.4 option at  
build.properties.default. We also strip the XML Parser and MX4J jars  
at the binary dist. I think most people use tomcat 5.5 with jdk 1.5.
Can I help to correct the build.xml's and test it? I have made a  
small test and it seems to work.

regards
Peter





Am 11.06.2007 um 10:17 schrieb Bill Barker:

>
> "Filip Hanik - Dev Lists" <devlists@hanik.com> wrote in message
> news:466CFE90.1070603@hanik.com...
>> so if we are not going to build the class, why would we include it  
>> in SVN
>> and document it? It wont be part of the release.
>>
>
> As has been going on in Jakarta-Commons, the release is the source  
> release.
> The binary is just gravy:).  The Connectors tree already (for a  
> very long
> time), has conditional dependancies on the JDK used to compile.
>
>> Filip
>>
>> Peter Rossbach wrote:
>>> Hi Filip,
>>>
>>> I found a simple way to build with Java 1.4.2.
>>>
>>> Index: container/catalina/build.xml
>>> ===================================================================
>>> --- container/catalina/build.xml    (revision 545449)
>>> +++ container/catalina/build.xml    (working copy)
>>> @@ -613,6 +613,7 @@
>>>        <exclude name="org/apache/naming/factory/ 
>>> SendMailFactory.java"/>
>>>        <exclude name="org/apache/catalina/launcher/**"/>
>>>        <exclude name="org/apache/catalina/valves/ 
>>> SemaphoreValve.java"/>
>>> +      <exclude
>>> name="org/apache/catalina/mbeans/ 
>>> JMXAdaptorLifecycleListener.java" />
>>>      </javac>
>>>      <tstamp>
>>>          <format property="TODAY" pattern="MMM d yyyy" locale="en"/>
>>> @@ -656,7 +657,9 @@
>>>         unless="compile.jsse"/>
>>>        <exclude name="org/apache/catalina/valves/ 
>>> SemaphoreValve.java"
>>>         unless="jdk.1.5.present"/>
>>> -    </javac>
>>> +      <exclude
>>> name="org/apache/catalina/mbeans/JMXAdaptorLifecycleListener.java"
>>> +       unless="jdk.1.5.present"/>
>>> +   </javac>
>>>      <!-- Copy static resource files -->
>>>      <filter token="VERSION" value="${version}"/>
>>> @@ -990,6 +993,7 @@
>>>          <exclude
>>> name="org/apache/catalina/valves/RequestDumperValve.class" />
>>>          <exclude
>>> name="org/apache/catalina/valves/RequestFilterValve.class" />
>>>          <exclude name="org/apache/catalina/valves/ 
>>> SemaphoreValve.class"
>>> />
>>> +        <exclude
>>> name="org/apache/catalina/mbeans/ 
>>> JMXAdaptorLifecycleListener.class" />
>>>        </fileset>
>>>      </jar>
>>> @@ -1025,6 +1029,7 @@
>>>          <include
>>> name="org/apache/catalina/valves/RequestDumperValve.class" />
>>>          <include
>>> name="org/apache/catalina/valves/RequestFilterValve.class" />
>>>          <include name="org/apache/catalina/valves/ 
>>> SemaphoreValve.class"
>>> />
>>> +        <include
>>> name="org/apache/catalina/mbeans/ 
>>> JMXAdaptorLifecycleListener.class" />
>>>          <!-- Javadoc and i18n exclusions -->
>>>          <exclude name="**/package.html" />
>>>
>>> Peter
>>>
>>>
>>>
>>> Am 08.06.2007 um 14:03 schrieb Filip Hanik - Dev Lists:
>>>
>>>> I'm gonna pull out your changes Peter, I was supposed to tag,  
>>>> but this
>>>> stuff doesn't build.
>>>> We're building Tomcat 5.5 using JDK 1.4.2 (that was the requirement
>>>> passed down to me) and this class uses JDK 1.5 imports RMI SSL  
>>>> factory
>>>> stuff.
>>>>
>>>> Filip
>>>>
>>>> pero@apache.org wrote:
>>>>> Author: pero
>>>>> Date: Mon Jun  4 23:19:13 2007
>>>>> New Revision: 544401
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=544401
>>>>> Log:
>>>>> Add JMXAdaptorLifecycleListener to start JMX Connector with fix  
>>>>> naming
>>>>> and data port. This feature is needed to have stable remote  
>>>>> access as
>>>>> your local firewall is activ.
>>>>>
>>>>> Added:
>>>>>
>>>>> tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ 
>>>>> mbeans/JMXAdaptorLifecycleListener.java
>>>>> (with props)
>>>>> Modified:
>>>>>     tomcat/container/tc5.5.x/webapps/docs/changelog.xml
>>>>>     tomcat/container/tc5.5.x/webapps/docs/monitoring.xml
>>>>>
>>>>> Added:
>>>>> tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ 
>>>>> mbeans/JMXAdaptorLifecycleListener.java
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/ 
>>>>> src/share/org/apache/catalina/mbeans/ 
>>>>> JMXAdaptorLifecycleListener.java?view=auto&rev=544401
>>>>> ================================================================== 
>>>>> ============
>>>>> ---
>>>>> tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ 
>>>>> mbeans/JMXAdaptorLifecycleListener.java
>>>>> (added)
>>>>> +++
>>>>> tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/ 
>>>>> mbeans/JMXAdaptorLifecycleListener.java
>>>>> Mon Jun  4 23:19:13 2007
>>>>> @@ -0,0 +1,355 @@
>>>>>
>>>>
>>>>
>>>> ------------------------------------------------------------------- 
>>>> --
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>>
>>>>
>>>
>>>
>>> -------------------------------------------------------------------- 
>>> ----
>>>
>>> No virus found in this incoming message.
>>> Checked by AVG Free Edition. Version: 7.5.472 / Virus Database:
>>> 269.8.11/837 - Release Date: 6/6/2007 2:03 PM
>>>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message