Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Tomcat Developers List" <dev@tomcat.apache.org>
Received-SPF: pass (herse.apache.org: local policy)
Message-ID: <4656AD10.1020109@hanik.com>
Date: Fri, 25 May 2007 11:32:00 +0200
From: Filip Hanik - Dev Lists <devlists@hanik.com>
User-Agent: Thunderbird 1.5.0.10 (Windows/20070221)
MIME-Version: 1.0
To: Tomcat Developers List <dev@tomcat.apache.org>
Subject: Re: svn commit: r541337 - in
 /tomcat/trunk/java/org/apache/catalina/connector:
 CometEventImpl.java CoyoteAdapter.java
References: <20070524154730.47AB51A981A@eris.apache.org>
 <4655B69D.9020604@apache.org>
In-Reply-To: <4655B69D.9020604@apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Remy Maucherat wrote:
> fhanik@apache.org wrote:
>> Author: fhanik
>> Date: Thu May 24 08:47:29 2007
>> New Revision: 541337
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=541337
>> Log:
>> Add in support to check if the current thread is a Tomcat 'worker' 
>> thread or not, that way we can decide if the invokations are 
>> appropriate or not
>
> I dislike this sort checks (mostly because of the ugly mechanics that 
> goes along, obviously). I don't really see the point either.
I know you do, however, it's not expensive, it's not a lot of code, and 
it will avoid a lot of bugs and questions on the user list.
Servlet programmers aren't really familiar with connection/poller 
mechanics, and we can't expect them to be either.
so what we need to do is that the API is so straight forward and throws 
the correct exceptions if they invoke methods that would interfere with 
the underlying connection asynchronously.

Filip

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org