Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 4553 invoked from network); 23 May 2007 17:48:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 May 2007 17:48:19 -0000 Received: (qmail 4385 invoked by uid 500); 23 May 2007 17:48:20 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 4107 invoked by uid 500); 23 May 2007 17:48:19 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 4096 invoked by uid 99); 23 May 2007 17:48:18 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2007 10:48:18 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [72.22.94.67] (HELO virtual.halosg.com) (72.22.94.67) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2007 10:48:11 -0700 Received: (qmail 32267 invoked from network); 23 May 2007 12:45:09 -0500 Received: from unknown (HELO ?192.168.2.3?) (195.216.52.112) by halosg.com with SMTP; 23 May 2007 12:45:09 -0500 Message-ID: <46547E10.8030703@hanik.com> Date: Wed, 23 May 2007 19:46:56 +0200 From: Filip Hanik - Dev Lists User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: Versioning in sources References: <1179936713.2535.8.camel@wlt.obsidian-studios.com> <46546DBE.2050607@hanik.com> <1179940723.3081.5.camel@wlt.obsidian-studios.com> In-Reply-To: <1179940723.3081.5.camel@wlt.obsidian-studios.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org aah, that makes sense. Remember that the release manager is carrying his/her own build.properties, and if you build from source, you should too. in there you override any properties needed. That is why all binary builds are correct, but your build isn't. what you are asking for is that we update build.properties.default before tagging a release, correct? Filip William L. Thomson Jr. wrote: > Filip, > > On Wed, 2007-05-23 at 18:37 +0200, Filip Hanik - Dev Lists wrote: > >> hey William, what are you referring to? any specific .java files that >> need a version number? >> > > Sorry should have been more specific, the problem lies in > build.properties.default > > >> I was under the impression that we only tag each build, and then there >> is a small sucker in a property file that we swap out. >> > > It's the prop file being neglected :) > > >> ie, when you start 5.5.23 then you see >> >> May 23, 2007 6:35:55 PM org.apache.catalina.core.StandardEngine start >> INFO: Starting Servlet Engine: Apache Tomcat/5.5.23 >> > > Not here, with 6.0.13 I get > > May 23, 2007 1:15:58 PM org.apache.catalina.core.StandardEngine start > INFO: Starting Servlet Engine: Apache Tomcat/6.0-snapshot > > With 5.5.23, I get > > May 23, 2007 1:17:01 PM org.apache.catalina.core.StandardEngine start > INFO: Starting Servlet Engine: Apache Tomcat/5.5 > > Not sure what that's about with 5.5.23, since the prop file has 5.5.20, > so should reflect that version but does not. > > 404, and other error pages also reflect the versions as shown in the log > file and prop file. > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org