tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: svn commit: r542247 - /tomcat/trunk/java/org/apache/catalina/connector/CometEventImpl.java
Date Mon, 28 May 2007 15:42:55 GMT
fhanik@apache.org wrote:
> +    /**
> +     * Current set of configurations
> +     */
> +    protected HashSet<CometConfiguration> cometConfigurations = new HashSet<CometConfiguration>(3);
> +
>      protected WorkerThreadCheck threadCheck = new WorkerThreadCheck();
>  
>      private static final Object threadCheckHolder = new Object();
> @@ -139,31 +144,47 @@
>      public void configure(CometEvent.CometConfiguration... options)
>          throws IOException, IllegalStateException {
>          checkWorkerThread();
> -        throw new UnsupportedOperationException();
> +        synchronized (cometConfigurations) {
> +            cometConfigurations.clear();
> +            for (CometEvent.CometConfiguration cc : options) {
> +                cometConfigurations.add(cc);
> +            }
> +            request.action(ActionCode.ACTION_COMET_CONFIGURE,options);
> +        }

As I said quite a few times already, I don't think this sort of design 
is a good idea. Since you're apparently not willing to discuss much 
and/or reconsider things at the moment (too busy coding, eh ? ;) ), I 
don't think I can properly participate in the development of this branch.

I will work on a separate codebase in the sandbox for the time being to 
implement my own views of non blocking functionality, and maybe we will 
be able to merge at some point later on. I will use a new "comet" folder 
in the sandbox for this (so it will be 
http://svn.apache.org/repos/asf/tomcat/sandbox/comet).

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message