tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: svn commit: r534021 - /tomcat/connectors/trunk/jk/native/common/jk_map.c
Date Tue, 01 May 2007 11:59:42 GMT
Hi Henri,
I've commited the change below because I think this is an oversight with all your recent changes;
the stat struct was not initialized with your change to jk_file_exists(f), and thus later
on
*modified = statbuf.st_mtime
was set from the uninitialized struct, and could never return someting useful in 'time_t modified'.

greets, Guenter.

> Author: fuankg
> Date: Tue May  1 04:53:37 2007
> New Revision: 534021

> URL: http://svn.apache.org/viewvc?view=rev&rev=534021
> Log:
> changed to use jk_stat() to initialite the stat struct so that *modified =
> statbuf.st_mtime can work.

> Modified:
>     tomcat/connectors/trunk/jk/native/common/jk_map.c

> Modified: tomcat/connectors/trunk/jk/native/common/jk_map.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common
> /jk_map.c?view=diff&rev=534021&r1=534020&r2=534021
> ==========================================================================
> ====
> --- tomcat/connectors/trunk/jk/native/common/jk_map.c (original)
> +++ tomcat/connectors/trunk/jk/native/common/jk_map.c Tue May  1 04:53:37
> 2007
> @@ -485,7 +485,7 @@
>      if (m && f) {
>          struct stat statbuf;
>          FILE *fp;
> -        if (jk_file_exists(f) != JK_TRUE)
> +        if (jk_stat(f, &statbuf) == -1)
>              return JK_FALSE;
>  #if defined(AS400) && !defined(AS400_UTF8)
>          fp = fopen(f, "r, o_ccsid=0");



> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message