Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 15078 invoked from network); 23 Apr 2007 09:14:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Apr 2007 09:14:40 -0000 Received: (qmail 28741 invoked by uid 500); 23 Apr 2007 09:14:42 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 28690 invoked by uid 500); 23 Apr 2007 09:14:41 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 28674 invoked by uid 99); 23 Apr 2007 09:14:41 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2007 02:14:41 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [212.27.42.36] (HELO smtp6-g19.free.fr) (212.27.42.36) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 23 Apr 2007 02:14:34 -0700 Received: from [192.168.0.1] (gou06-1-82-224-99-120.fbx.proxad.net [82.224.99.120]) by smtp6-g19.free.fr (Postfix) with ESMTP id 2FF5A6D73A for ; Mon, 23 Apr 2007 11:14:13 +0200 (CEST) Message-ID: <462C78E4.5080008@apache.org> Date: Mon, 23 Apr 2007 11:14:12 +0200 From: Remy Maucherat User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r531306 - in /tomcat: container/tc5.5.x/catalina/src/share/org/apache/catalina/core/ container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ container/tc5.5.x/webapps/docs/ jasper/tc5.5.x/src/share/org/apache/jasper/runtime/ References: <20070423003244.202B81A9838@eris.apache.org> In-Reply-To: <20070423003244.202B81A9838@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Checked: Checked by ClamAV on apache.org markt@apache.org wrote: > Modified: tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java > URL: http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java?view=diff&rev=531306&r1=531305&r2=531306 > ============================================================================== > --- tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java (original) > +++ tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java Sun Apr 22 17:32:43 2007 > @@ -101,8 +101,6 @@ > * Constructor. > */ > PageContextImpl(JspFactory factory) { > - log = LogFactory.getLog(getClass()); > - > this.variableResolver = new VariableResolverImpl(this); > this.outs = new BodyContentImpl[0]; > this.attributes = new Hashtable(16); > @@ -130,6 +128,8 @@ > boolean autoFlush) throws IOException { > > // initialize state > + log = LogFactory.getLog(getClass()); > + I didn't see it a few hours ago (it was late), but this change has the same problem as the change for the application dispatcher, so it is also not good. This issue is about fighting against a windmill: it will continue happening with any class which is not loaded before starting the application, or if the logger is acquired as part of the object creation if it's an instance field. Given that I consider these changes to not be acceptable, you cannot possibly fix this non issue. Rémy --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org