Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 6698 invoked from network); 13 Apr 2007 15:32:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 13 Apr 2007 15:32:51 -0000 Received: (qmail 89235 invoked by uid 500); 13 Apr 2007 15:32:48 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 89121 invoked by uid 500); 13 Apr 2007 15:32:47 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 89076 invoked by uid 500); 13 Apr 2007 15:32:47 -0000 Delivered-To: apmail-jakarta-tomcat-dev@jakarta.apache.org Received: (qmail 89062 invoked by uid 99); 13 Apr 2007 15:32:47 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2007 08:32:47 -0700 X-ASF-Spam-Status: No, hits=-99.5 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 13 Apr 2007 08:32:40 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id 67DDC1A9838; Fri, 13 Apr 2007 08:32:20 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Date: Fri, 13 Apr 2007 15:32:20 -0000 To: tomcat-dev@jakarta.apache.org From: fhanik@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20070413153220.67DDC1A9838@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: fhanik Date: Fri Apr 13 08:32:19 2007 New Revision: 528524 URL: http://svn.apache.org/viewvc?view=rev&rev=528524 Log: This write has to be synchronized since comet can write to the buffer and cause a buffer overflow if more than one thread is writing Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Modified: tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java?view=diff&rev=528524&r1=528523&r2=528524 ============================================================================== --- tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java (original) +++ tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java Fri Apr 13 08:32:19 2007 @@ -603,7 +603,7 @@ } int total = 0; - private void addToBB(byte[] buf, int offset, int length) throws IOException { + private synchronized void addToBB(byte[] buf, int offset, int length) throws IOException { if (socket.getBufHandler().getWriteBuffer().remaining() < length) { flushBuffer(); } --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org