From dev-return-80641-apmail-tomcat-dev-archive=tomcat.apache.org@tomcat.apache.org Tue Apr 24 18:00:39 2007 Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 54037 invoked from network); 24 Apr 2007 18:00:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Apr 2007 18:00:38 -0000 Received: (qmail 95366 invoked by uid 500); 24 Apr 2007 18:00:40 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 95322 invoked by uid 500); 24 Apr 2007 18:00:40 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 95311 invoked by uid 99); 24 Apr 2007 18:00:40 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2007 11:00:40 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [195.227.30.246] (HELO datura.kippdata.de) (195.227.30.246) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Apr 2007 11:00:32 -0700 Received: from [10.43.1.242] ([10.43.1.242]) by datura.kippdata.de (8.13.5/8.13.5) with ESMTP id l3OI0AMt025651 for ; Tue, 24 Apr 2007 20:00:10 +0200 (CEST) Message-ID: <462E459C.4020100@kippdata.de> Date: Tue, 24 Apr 2007 19:59:56 +0200 From: Rainer Jung User-Agent: Thunderbird 1.5.0.10 (Windows/20070221) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c References: <20070424154643.65E061A9838@eris.apache.org> In-Reply-To: <20070424154643.65E061A9838@eris.apache.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Hi Henri, could you please remove the tabs ... This change here I don't understand: when we set main_log we register for this function call. We only send main_log as an argument, so now on iSeries whenever jklog_cleanup runs, we set main_log to NULL twice. Why should that be better than doing it once per call? Regards, Rainer hgomez@apache.org schrieb: > Author: hgomez > Date: Tue Apr 24 08:46:42 2007 > New Revision: 531988 > > URL: http://svn.apache.org/viewvc?view=rev&rev=531988 > Log: > On i5/OS it seems mandatory to reset the main_log. tested on an Apache instance with multi virtual hosts and it's required... > > Modified: > tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c > > Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c > URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531988&r1=531987&r2=531988 > ============================================================================== > --- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original) > +++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:46:42 2007 > @@ -2545,6 +2545,10 @@ > static apr_status_t jklog_cleanup(void *d) > { > /* set the main_log to NULL */ > +#ifdef AS400 > + main_log = NULL; > +#endif > + > d = NULL; > return APR_SUCCESS; > } > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org