tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42025] New: - Incorrect documentation in RemoteAddrValve/RemoteHostValve
Date Mon, 02 Apr 2007 23:22:49 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42025>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42025

           Summary: Incorrect documentation in
                    RemoteAddrValve/RemoteHostValve
           Product: Tomcat 5
           Version: 5.5.23
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Webapps:Documentation
        AssignedTo: tomcat-dev@jakarta.apache.org
        ReportedBy: renaud+apache@waldura.com


The documentation page at http://tomcat.apache.org/tomcat-5.5-
doc/config/valve.html says:

"The syntax for regular expressions is different than that for 'standard' 
wildcard matching. Tomcat uses the Jakarta Regexp library. Please consult the 
Regexp documentation for details of the expressions supported."

This is incorrect. In reality, the standard Java regexp package java.util.regex 
is used. The syntax is slightly different than Jakarta Regexp. In particular, 
the matches() method is used by RemoteAddrValve/RemoteHostValve, which attempts 
to match the entire region against the pattern. 

E.g. I expected
<Valve allow="^127\." ...
to match localhost addresses. But this doesn't work, I must write 
<Valve allow="127\.0\.0\.\d" ...
because the *entire* region is matched with java.util.regex. (Note the lack of 
anchor.)

(While I'm reporting this as a documentation issue, it could also be viewed as 
a feature regression since region matches were previously supported, as far as 
I can tell.)

NOTE: I'm logging this problem against 5.5, but it also exists in the 6.0 
documentation.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message