tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r531988 - /tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
Date Tue, 24 Apr 2007 17:59:56 GMT
Hi Henri,

could you please remove the tabs ...

This change here I don't understand: when we set main_log we register
for this function call. We only send main_log as an argument, so now on
iSeries whenever jklog_cleanup runs, we set main_log to NULL twice. Why
should that be better than doing it once per call?

Regards,

Rainer

hgomez@apache.org schrieb:
> Author: hgomez
> Date: Tue Apr 24 08:46:42 2007
> New Revision: 531988
> 
> URL: http://svn.apache.org/viewvc?view=rev&rev=531988
> Log:
> On i5/OS it seems mandatory to reset the main_log. tested on an Apache instance with
multi virtual hosts and it's required...
> 
> Modified:
>     tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> 
> Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
> URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diff&rev=531988&r1=531987&r2=531988
> ==============================================================================
> --- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
> +++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 24 08:46:42 2007
> @@ -2545,6 +2545,10 @@
>  static apr_status_t jklog_cleanup(void *d)
>  {
>      /* set the main_log to NULL */
> +#ifdef AS400
> +	main_log = NULL;
> +#endif
> +
>      d = NULL;
>      return APR_SUCCESS;
>  }
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message