tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: svn commit: r531306 - in /tomcat: container/tc5.5.x/catalina/src/share/org/apache/catalina/core/ container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ container/tc5.5.x/webapps/docs/ jasper/tc5.5.x/src/share/org/apache/jasper/runtime/
Date Mon, 23 Apr 2007 09:14:12 GMT
markt@apache.org wrote:
> Modified: tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java
> URL: http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java?view=diff&rev=531306&r1=531305&r2=531306
> ==============================================================================
> --- tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java (original)
> +++ tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/runtime/PageContextImpl.java Sun
Apr 22 17:32:43 2007
> @@ -101,8 +101,6 @@
>       * Constructor.
>       */
>      PageContextImpl(JspFactory factory) {
> -        log = LogFactory.getLog(getClass());
> -
>          this.variableResolver = new VariableResolverImpl(this);
>          this.outs = new BodyContentImpl[0];
>          this.attributes = new Hashtable(16);
> @@ -130,6 +128,8 @@
>                               boolean autoFlush) throws IOException {
>  
>          // initialize state
> +        log = LogFactory.getLog(getClass());
> +

I didn't see it a few hours ago (it was late), but this change has the 
same problem as the change for the application dispatcher, so it is also 
not good. This issue is about fighting against a windmill: it will 
continue happening with any class which is not loaded before starting 
the application, or if the logger is acquired as part of the object 
creation if it's an instance field. Given that I consider these changes 
to not be acceptable, you cannot possibly fix this non issue.

Rémy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message