tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r531306 - in /tomcat: container/tc5.5.x/catalina/src/share/org/apache/catalina/core/ container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ container/tc5.5.x/webapps/docs/ jasper/tc5.5.x/src/share/org/apache/jasper/runtime/
Date Mon, 23 Apr 2007 01:16:18 GMT
Remy Maucherat wrote:
> markt@apache.org wrote:
>>  public abstract class ManagerBase implements Manager,
>> MBeanRegistration {
>> -    protected Log log = LogFactory.getLog(ManagerBase.class);
>> +    protected Log log = null;
> 
> I'm also fairly certain this causes NPEs, so this part of the change has
> to be reverted as well (for example, calling setRandomFile). This issue
> is good to fix, as I have pointed out in the bug report.

I did check this and couldn't see a code path that would call this
prior to init() being called. What am I missing?

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message