tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Remy Maucherat <r...@apache.org>
Subject Re: svn commit: r531306 - in /tomcat: container/tc5.5.x/catalina/src/share/org/apache/catalina/core/ container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ container/tc5.5.x/webapps/docs/ jasper/tc5.5.x/src/share/org/apache/jasper/runtime/
Date Mon, 23 Apr 2007 00:56:57 GMT
markt@apache.org wrote:
> Modified: tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ManagerBase.java
> URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ManagerBase.java?view=diff&rev=531306&r1=531305&r2=531306
> ==============================================================================
> --- tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ManagerBase.java
(original)
> +++ tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/session/ManagerBase.java
Sun Apr 22 17:32:43 2007
> @@ -62,7 +62,7 @@
>   */
>  
>  public abstract class ManagerBase implements Manager, MBeanRegistration {
> -    protected Log log = LogFactory.getLog(ManagerBase.class);
> +    protected Log log = null;

I'm also fairly certain this causes NPEs, so this part of the change has 
to be reverted as well (for example, calling setRandomFile). This issue 
is good to fix, as I have pointed out in the bug report.

Rémy


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message