tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Hanik - Dev Lists <devli...@hanik.com>
Subject Re: svn commit: r528524 - /tomcat/tc6.0.x/trunk/java/org/apache/coyote/http11/InternalNioOutputBuffer.java
Date Sat, 14 Apr 2007 05:35:08 GMT
Remy Maucherat wrote:
> Filip Hanik - Dev Lists wrote:
>> Lets say you have two threads writing to the response (async write 
>> from comet)
>> both of them could end up on the line:
>> socket.getBufHandler().getWriteBuffer().put(buf, offset, length);
>>
>> assuming nothing is synced in the path down to here, hence causing a 
>> buffer overflow,
>> Does that makes sense or am I smoking crack?
>
> I know, but this doesn't make sense to me, since it will already do 
> thread safety problems in the servlet layer (where there are buffers, 
> etc). If people want to have more than one thread writing, they have 
> to sync. I will not be adding similar checks in the APR connector, but 
> you can leave them in the NIO connector if you feel more comfortable 
> with them.
I agree with you, but I'll save the rework of some of this for the next 
release, I believe I got the connector to a stable point now, don't 
wanna muck too much with it.
Filip
>
> Rémy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message