tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42198] - Insufficient synchronization for CometEvent.close
Date Tue, 24 Apr 2007 21:04:57 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42198>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42198





------- Additional Comments From daniel.doubleday@gmx.net  2007-04-24 14:04 -------
Hi, I know that this is no discussion forum but I wanted to comment on

(In reply to comment #8)
> - in svn head, you will get an END event in certain cases (like if the event or
> stream is closed asynchronously), but it is not required to close the event
> again since it's been done already; if the request is closed synchronously ...

If and when you get an END event depends very much on the connection type you
are using.

When you are using a Keep-Alive connection you dont get an END event when
calling event.close() synchronously. You will get it at some point later when
the browser decides to release the connection.

Otherwise (Connection: close) the connection will be released instantly and an
END event will be triggered. In that case the comet event object will become
kind of invalid, because if you call event.close() a NullPointerException will
by thrown. Unfortunately there is no way to query the event if it is already
closed. 

Personally I find that the event.close() method should never fail in that way
but rather return silently when being called on a closed event.

I wonder if there is a way to close the connection from the server side (other
than using Connection: close).

It's also a bit strange that you can keep on writing into a response output
stream of a closed event without getting an error when using Keep-Alive
connections. It seems to me that an exception should be thrown when trying to
write. 

Just my 5C


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message