tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 42198] - Insufficient synchronization for CometEvent.close
Date Tue, 24 Apr 2007 00:36:19 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=42198>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42198





------- Additional Comments From remm@apache.org  2007-04-23 17:36 -------
I think there are a few sync strategies which can work.

- I think there is no reason to stop using a single event instance
- the ChatServlet only has one main thread writing (the others are there to add
stuff to do), so there is no unnecessary contention
- event.close indeed does a close, but it may not make a real difference
(because the stream close also ends the response)
- in svn head, you will get an END event in certain cases (like if the event or
stream is closed asynchronously), but it is not required to close the event
again since it's been done already; if the request is closed synchronously
during processing of the event method, for example when processing a timeout,
you will not get another END event; there's a valve which provides additional
END events (on session expiration, etc)

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message