tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabien Carrion" <fabien.carr...@gmail.com>
Subject Re: Annotation processing - Geronimo injection
Date Sun, 25 Mar 2007 01:26:24 GMT
Hi,

Here is my point of view.

I like the idea of "<create a new instance through various kinds of
magic>" to be replaced by "nice code that can do the object creation
and  injection in one step".
As I am still new on the code of Tomcat, having all the code
concentrated for the object creation and injection is a good idea. I
remember to have problem to find out where the filter, servlet...
objects were created when I did my first patch on the annotations. But
I have no solution to implement it on tomcat.

The patch doesn't seems to modify nothing on the catalina side
(ContextConfig.java, WebRuleSet.java, WebAnnotationSet.java). Just the
jasper side is taken in account.

I don't think an adapter between the LifecycleProvider interface and the
AnnotationProcessor interface is a good idea. This is one layer more
between the code which does the work and the code which requires the
work. The adapter has to be maintained. It is more work for us.

Cheer's

Fabien


On 3/24/07, Filip Hanik - Dev Lists <devlists@hanik.com> wrote:
> yo,
> I've been in touch with the folks at Geronimo.
> They use dependency injection, and have a suggestion on how they would
> like the annotation processor to be able to be injected into tomcat
>
> Here is the email
> http://marc.info/?l=geronimo-dev&m=117467149802844&w=2
>
> Here is the proposed patch:
> https://issues.apache.org/jira/secure/attachment/12354097/GERONIMO-3010-1.patch
>
> I'd take out the word LifecycleProvider, and replace it with something
> else as it conflicts with our own idea of Lifecycle.
>
> I'd like to get your feedback, this is a chance step for our two
> communities to work together.
>
> Filip
>


-- 
Fabien Carrion

()  Campagne du ruban ASCII -- Contre les mails en html
/\  contre les pieces-jointes Microsoft
Web: http://fabien.carrion.free.fr/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message