Return-Path: Delivered-To: apmail-tomcat-dev-archive@www.apache.org Received: (qmail 51744 invoked from network); 4 Feb 2007 19:24:07 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Feb 2007 19:24:07 -0000 Received: (qmail 5716 invoked by uid 500); 4 Feb 2007 19:24:07 -0000 Delivered-To: apmail-tomcat-dev-archive@tomcat.apache.org Received: (qmail 5686 invoked by uid 500); 4 Feb 2007 19:24:06 -0000 Mailing-List: contact dev-help@tomcat.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Tomcat Developers List" Delivered-To: mailing list dev@tomcat.apache.org Received: (qmail 5664 invoked by uid 99); 4 Feb 2007 19:24:06 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Feb 2007 11:24:06 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [195.227.30.246] (HELO datura.kippdata.de) (195.227.30.246) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Feb 2007 11:23:57 -0800 Received: from [192.168.2.114] ([192.168.2.114]) by datura.kippdata.de (8.13.5/8.13.5) with ESMTP id l14JNXcD021287 for ; Sun, 4 Feb 2007 20:23:34 +0100 (CET) Message-ID: <45C63435.9040303@kippdata.de> Date: Sun, 04 Feb 2007 20:29:57 +0100 From: Rainer Jung User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Tomcat Developers List Subject: Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h References: <20070202162754.88FC21A981A@eris.apache.org> <45C37165.9060906@kippdata.de> <25A80391-77EF-429D-AC36-DD52EA5401D8@jaguNET.com> <45C376AB.2070104@kippdata.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org You are right. Jim Jagielski wrote: > > On Feb 2, 2007, at 12:36 PM, Rainer Jung wrote: > >> I can't test on HP-UX, but maybe you (jfc) could try: >> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) && >> !defined(HPUX11) >> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) && >> !defined(HAVE_SYS_SOCKETVAR_H) >> #include >> #endif >> -#if !defined(HPUX11) && !defined(AS400) >> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400) >> #include >> #endif >> #endif >> > > Hmmm.... Isn't that backwards? Don't we want to > include these headers if the autoconf macros *are* > defined? > > So why not just: > > #if defined(HAVE_SYS_SOCKETVAR_H) > #include > #endif > #if defined(HAVE_SYS_SELECT_H) > #include > #endif > > or I must be missing something (wouldn't be the 1st time) :) > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org > For additional commands, e-mail: dev-help@tomcat.apache.org > -- kippdata informationstechnologie GmbH Bornheimer Str. 33a 53111 Bonn Tel.: 0228/98549-0 Fax: 0228/98549-50 www.kippdata.de ======================= kippdata informationstechnologie GmbH Bornheimer Str. 33a D-53111 Bonn Tel.: +49/0228/98549-0 Fax: +49/0228/98549-50 www.kippdata.de --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org For additional commands, e-mail: dev-help@tomcat.apache.org