tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Date Sun, 04 Feb 2007 19:29:57 GMT
You are right.

Jim Jagielski wrote:
> 
> On Feb 2, 2007, at 12:36 PM, Rainer Jung wrote:
> 
>> I can't test on HP-UX, but maybe you (jfc) could try:
>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
&& 
>> !defined(HPUX11)
>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
&& 
>> !defined(HAVE_SYS_SOCKETVAR_H)
>>  #include <sys/socketvar.h>
>>  #endif
>> -#if !defined(HPUX11) && !defined(AS400)
>> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
>>  #include <sys/select.h>
>>  #endif
>>  #endif
>>
> 
> Hmmm.... Isn't that backwards? Don't we want to
> include these headers if the autoconf macros *are*
> defined?
> 
> So why not just:
> 
>    #if defined(HAVE_SYS_SOCKETVAR_H)
>    #include <sys/socketvar.h>
>    #endif
>    #if defined(HAVE_SYS_SELECT_H)
>    #include <sys/select.h>
>    #endif
> 
> or I must be missing something (wouldn't be the 1st time) :)
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
> 

-- 
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
53111 Bonn

Tel.: 0228/98549-0
Fax:  0228/98549-50
www.kippdata.de
=======================
kippdata informationstechnologie GmbH
Bornheimer Str. 33a
D-53111 Bonn

Tel.: +49/0228/98549-0
Fax:  +49/0228/98549-50
www.kippdata.de

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message