tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jean-frederic Clere <jfcl...@gmail.com>
Subject Re: svn commit: r502649 - /tomcat/connectors/trunk/jk/native/common/jk_global.h
Date Fri, 02 Feb 2007 18:26:21 GMT
Rainer Jung wrote:

> I can't test on HP-UX, but maybe you (jfc) could try:


The problem is that sys/socketvar.h can't be compiled using gcc and I 
think we don't need it HP-UX (for example APR doesn't include it).
I will test the modifications in configure.in later.

Cheers

Jean-Frederic

> Index: configure.in
> ===================================================================
> --- configure.in        (revision 502659)
> +++ configure.in        (working copy)
> @@ -139,6 +139,10 @@
>  dnl check for filio.h used on Solaris to define FIONREAD ioctl.
>  AC_CHECK_HEADERS(sys/filio.h)
>
> +dnl check for socketvar.h and select.h not used on HPUX11
> +AC_CHECK_HEADERS(sys/socketvar.h)
> +AC_CHECK_HEADERS(sys/select.h)
> +
>  AC_DEFUN([JK_CHECK_SETSOCKOPT], [
>  AC_MSG_CHECKING(whether to use $1 with setsockopt())
>  AC_TRY_RUN([
> Index: common/jk_global.h
> ===================================================================
> --- common/jk_global.h  (revision 502659)
> +++ common/jk_global.h  (working copy)
> @@ -142,10 +142,10 @@
>  #include <netinet/tcp.h>
>  #include <arpa/inet.h>
>  #include <sys/un.h>
> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&

> !defined(HPUX11)
> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN) &&

> !defined(HAVE_SYS_SOCKETVAR_H)
>  #include <sys/socketvar.h>
>  #endif
> -#if !defined(HPUX11) && !defined(AS400)
> +#if !defined(HAVE_SYS_SELECT_H) && !defined(AS400)
>  #include <sys/select.h>
>  #endif
>  #endif
>
> Of course you would need to rebuild configure via buildconf.sh after 
> changing configure.in.
>
> Regards,
>
> Rainer
>
>
> Jim Jagielski wrote:
>
>> Don't we also have a HPUX11 specific check like
>> the 2nd line after this one? Seems consistent to me :/
>>
>> On Feb 2, 2007, at 12:14 PM, Rainer Jung wrote:
>>
>>> Hi Jean-Frederic,
>>>
>>> shouldn't we be able to find out about the necessity to include it 
>>> via configure? At least HP-UX should be able to use the configure 
>>> mechanism. I think we mostly use the hard coded defines for the 
>>> platforms, where we can't use the configure mechanism.
>>>
>>> Regards,
>>>
>>> Rainer
>>>
>>> jfclere@apache.org wrote:
>>>
>>>> Author: jfclere
>>>> Date: Fri Feb  2 08:27:53 2007
>>>> New Revision: 502649
>>>> URL: http://svn.apache.org/viewvc?view=rev&rev=502649
>>>> Log:
>>>> Otherwise it doesn't compile with gcc on HPUX.
>>>> Modified:
>>>>     tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>> Modified: tomcat/connectors/trunk/jk/native/common/jk_global.h
>>>> URL: 
>>>> http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_global.h?view=diff&rev=502649&r1=502648&r2=502649

>>>>
>>>> ==============================================================================

>>>>
>>>> --- tomcat/connectors/trunk/jk/native/common/jk_global.h (original)
>>>> +++ tomcat/connectors/trunk/jk/native/common/jk_global.h Fri Feb  2 
>>>> 08:27:53 2007
>>>> @@ -142,7 +142,7 @@
>>>>  #include <netinet/tcp.h>
>>>>  #include <arpa/inet.h>
>>>>  #include <sys/un.h>
>>>> -#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
>>>> +#if !defined(_OSD_POSIX) && !defined(AS400) && !defined(CYGWIN)
&& 
>>>> !defined(HPUX11)
>>>>  #include <sys/socketvar.h>
>>>>  #endif
>>>>  #if !defined(HPUX11) && !defined(AS400)
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>>
>>> --kippdata informationstechnologie GmbH
>>> Bornheimer Str. 33a
>>> 53111 Bonn
>>>
>>> Tel.: 0228/98549-0
>>> Fax:  0228/98549-50
>>> www.kippdata.de
>>> =======================
>>> kippdata informationstechnologie GmbH
>>> Bornheimer Str. 33a
>>> D-53111 Bonn
>>>
>>> Tel.: +49/0228/98549-0
>>> Fax:  +49/0228/98549-50
>>> www.kippdata.de
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message