tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fha...@apache.org
Subject svn commit: r513060 - in /tomcat/tc6.0.x/trunk: java/org/apache/tomcat/util/net/SocketProperties.java webapps/docs/config/http.xml
Date Wed, 28 Feb 2007 23:28:39 GMT
Author: fhanik
Date: Wed Feb 28 15:28:35 2007
New Revision: 513060

URL: http://svn.apache.org/viewvc?view=rev&rev=513060
Log:
By default dont use direct buffers, in a situation where a very large number of connections,
direct buffers are much slower

Modified:
    tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java
    tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml

Modified: tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java?view=diff&rev=513060&r1=513059&r2=513060
==============================================================================
--- tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java (original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/tomcat/util/net/SocketProperties.java Wed Feb 28
15:28:35 2007
@@ -18,24 +18,24 @@
 import java.net.Socket;
 import java.net.SocketException;
 /**
- * Properties that can be set in the <Connector> element 
+ * Properties that can be set in the <Connector> element
  * in server.xml. All properties are prefixed with "socket."
  * and are currently only working for the Nio connector
- * 
+ *
  * @author Filip Hanik
  */
 public class SocketProperties {
     /**
-     * Enable/disable key cache, this bounced cache stores 
+     * Enable/disable key cache, this bounced cache stores
      * KeyAttachment objects to reduce GC
      * Default is 100
      * -1 is unlimited
      * 0 is disabled
      */
     protected int keyCache = 500;
-    
+
     /**
-     * Enable/disable poller event cache, this bounded cache stores 
+     * Enable/disable poller event cache, this bounded cache stores
      * PollerEvent objects to reduce GC for the poller
      * Default is -1 (unlimited)
      * -1 is unlimited
@@ -43,13 +43,13 @@
      * >0 the max number of objects to keep in cache.
      */
     protected int eventCache = 500;
-    
+
 
     /**
      * Enable/disable direct buffers for the network buffers
      * Default value is enabled
      */
-    protected boolean directBuffer = true;
+    protected boolean directBuffer = false;
     /**
      * Socket receive buffer size in bytes (SO_RCVBUF)
      * Default value is 25188
@@ -60,19 +60,19 @@
      * Default value is 43800
      */
     protected int txBufSize = 43800;
-    
+
     /**
      * The application read buffer size in bytes.
      * Default value is rxBufSize
      */
     protected int appReadBufSize = 8192;
-    
+
     /**
      * The application write buffer size in bytes
      * Default value is txBufSize
      */
     protected int appWriteBufSize = 8192;
-    
+
     /**
      * NioChannel pool size for the endpoint,
      * this value is how many channels
@@ -80,7 +80,7 @@
      * Default value is 500
      */
     protected int bufferPool = 500;
-    
+
 
     /**
      * Buffer pool size in bytes to be cached
@@ -88,7 +88,7 @@
      * Default value is 100MB (1024*1024*100 bytes)
      */
     protected int bufferPoolSize = 1024*1024*100;
-    
+
     /**
      * TCP_NO_DELAY option, default is true
      */

Modified: tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml?view=diff&rev=513060&r1=513059&r2=513060
==============================================================================
--- tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/config/http.xml Wed Feb 28 15:28:35 2007
@@ -413,7 +413,7 @@
         <p>Whether to allow comet servlets or not, Default value is true.</p>
       </attribute>
       <attribute name="socket.directBuffer" required="false">
-        <p>Boolean value, whether to use direct ByteBuffers or java mapped ByteBuffers.
Default is <code>true</code>
+        <p>Boolean value, whether to use direct ByteBuffers or java mapped ByteBuffers.
Default is <code>false</code>
            <br/>When you are using direct buffers, make sure you allocate the appropriate
amount of memory for the 
                 direct memory space. On Sun's JDK that would be something like <code>-XX:MaxDirectMemorySize=256m</code></p>
       </attribute>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message