tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r500716 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/core/StandardWrapper.java java/org/apache/catalina/valves/ErrorReportValve.java webapps/docs/changelog.xml
Date Mon, 29 Jan 2007 01:38:38 GMT
Remy Maucherat wrote:
> Mark Thomas wrote:
>> An alternative approach that has since occurred to me is to modify
>> JspException in the same way as ServletException so the standard
>> exception chaining is always used. This would enable getCause to be
>> used in all cases apart from SQLException and allow a much cleaner
>> patch whilst retaining improved root cause identification.
>>
>> Having now just looked at the JavaDoc for JspException in the JSP 2.1
>> final spec we have to make this change to be spec compliant.
>> getRootCause has been deprecated in favour of getCause.
>>
>> I'll make the changes later today.
> 
> I think it's better if I veto this patch, then. The previous code was
> simpler, complied with the new Java standard for exception nesting, and
> had better protections against infinite loops. Using getCause is the
> standard way of unwrapping exceptions, and should be used moving forward.

Fair enough. My biggest concern was the lack of JspException
unwrapping. The SQLException support was a nice to have but I'm not
that bothered about it.

> Note: I see you have fixed JspException as ServletException has been
> fixed earlier.

I am assuming the veto doesn't apply to this.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message