tomcat-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 39088] - StandardWrapper getRootCause() infinite loop
Date Mon, 15 Jan 2007 11:49:26 GMT
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39088>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39088


wouter.zelle@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |NEW




------- Additional Comments From wouter.zelle@gmail.com  2007-01-15 03:49 -------
Mark,

Thanks for working on this issue. Your change still results in potentially
dangerous invocations of getRootCause on third-party classes, though. This fix
does not have that flaw and is much cleaner overall:

public static Throwable getRootCause(ServletException e) {
    Throwable rootCause = e.getRootCause();
    if (rootCause instanceof ServletException
        && rootCause != e) {
        rootCause = getRootCause((ServletException) rootCause);
    }
    return rootCause;
}

Could you please review it?

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Mime
View raw message